-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run plugin #82
base: master
Are you sure you want to change the base?
Run plugin #82
Conversation
I have restructured the plugin a bit local config = require "core.config"
local run = require "plugins.run"
local command = require "core.command"
local keymap = require "core.keymap"
config.run.love2d = "love ."
command.add(nil, {
["run:love2d"] = run.lang "love2d",
})
keymap.add {
["shift+f5"] = "run:love2d",
} |
It will now always choose the longest match
Have you seen the console plugin? I get the impression it may already solve the issue your plugin is trying to solve |
Yes, I have used it, but I couldn't get it to work with infinite loops in my scripts, it didn't allow me to get user input, etc., so I've decided to use the native terminal and made this little plugin |
I do see a niche usage for this idea. Sometimes I do work on standalone scripts that I don't have a project hook for. lite would require sockets in C-portion of code to enable a host of similar usages like this one where communication between a running application and lite is required. May I suggest naming this plugin something like runinterminal, to be more descriptive, if it should be accepted as independent plugin? |
@SwissalpS good idea, I have renamed the plugin name to |
This is hard-coding the gnome terminal on non-windows systems. I suggest to use an env-variable and default to gnome-terminal if not set. |
I looked into it, although I am using a non-standard variable |
I have also added a |
@Qermon did you forget to switch branch? :D |
Thankfully not, just resolving conflicts with rxi:master |
Oh, sorry. I now see what happened :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use a config setting for this? I use termit mostly and would change that and other arguments for my usage case.
Pretty sure there are others who have a favourite terminal that is not setup as xterm/gnome-terminal override.
You can actually change it by putting something like |
But if the default can already respect the user command in a non-breaking way, why should we force them? |
Well, I've realized that |
f5
or use therun:run-doc
commandYou can also add, for example, love2d support to your project module